add option to capture cliCommand output#197
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for extracting values from CLI command stdout into shared lesson variables, and ensures parse/validation errors for that extraction are reported during local CLI evaluation.
Changes:
- Introduce
stdoutVariableson CLI command steps, with{name, regex}definitions. - Parse command stdout using regex capture groups and store matches into the shared variables map.
- Surface stdout-variable parsing errors in local evaluation via a new
Errfield onCLICommandResult, plus new tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| client/lessons.go | Extends CLI lesson schema with stdoutVariables and adds Err to CLI command results for local error surfacing. |
| checks/cli.go | Implements stdout-variable parsing via regex capture groups and propagates parse errors back through command results. |
| checks/local.go | Fails local evaluation early when a CLI command result contains a parse error (result.Err). |
| checks/local_test.go | Adds coverage to ensure local evaluation reports stdout-variable parse errors as structured failures. |
| checks/cli_test.go | Adds tests for capturing stdout variables and interpolating captured values into subsequent commands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
theodore-s-beers
force-pushed
the
tsb_cli_stdout
branch
from
3057b67 to
a502e20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stdoutVariablessupport for CLI command stepsstdoutvariable parse errors in local CLI evaluation